Merge pull request #407 from Art4/fix-php84-deprecation-warnings

PHP 8.4 Fix implicitly nullable parameter declarations deprecations
kbsali · Jun 27, 2024 · be7c256 · be7c256
2 parents 31768d5 + cc14f15
commit be7c256
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/Redmine/Client/NativeCurlClient.php b/src/Redmine/Client/NativeCurlClient.php
@@ -36,7 +36,7 @@ final class NativeCurlClient implements Client, HttpClient
     public function __construct(
         string $url,
         string $apikeyOrUsername,
-        string $password = null
+        ?string $password = null
     ) {
         $this->url = $url;
         $this->apikeyOrUsername = $apikeyOrUsername;

diff --git a/src/Redmine/Client/Psr18Client.php b/src/Redmine/Client/Psr18Client.php
@@ -45,7 +45,7 @@ public function __construct(
         StreamFactoryInterface $streamFactory,
         string $url,
         string $apikeyOrUsername,
-        string $password = null
+        ?string $password = null
     ) {
         if (! $requestFactory instanceof RequestFactoryInterface && $requestFactory instanceof ServerRequestFactoryInterface) {
             @trigger_error(

diff --git a/src/Redmine/Exception/UnexpectedResponseException.php b/src/Redmine/Exception/UnexpectedResponseException.php
@@ -21,7 +21,7 @@ final class UnexpectedResponseException extends RuntimeException implements Redm
      */
     private $response = null;
 
-    public static function create(Response $response, Throwable $prev = null): self
+    public static function create(Response $response, ?Throwable $prev = null): self
     {
         $e = new self(
             'The Redmine server replied with an unexpected response.',