Generalize encode/decode for datasets #415
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably most controversial here is the addition of `data/*/samples/*`. I was using this to save sample prompts for datasets. Happy to drop it if its inclusion is not desired. The other things are all common things you'd want to gitignore: venv directories, vs-code workspaces, output directories (using the directory names suggested by this codebase), and the default wandb output directory.
This fixes a TODO to allow arbitrary encoding/decoding schemes for different datasets. To do so, I switched from pickle to dill, which extends pickle to enable things like pickling functions, including their referenced globals. dill is already a dependency of datasets, so this doesn't add any new dependencies.
|
I also did a similar thing on my personal work, recommended. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO to allow arbitrary encoding/decoding schemes for
different datasets. To do so, I switched from pickle to dill, which
extends pickle to enable things like pickling functions, including
their referenced globals. dill is already a dependency of datasets,
so this doesn't add any new dependencies.
This PR also includes some gitignore additions that I found
necessary for my usage. I can alter the entries, remove it from this
PR, or break it into a separate PR, as you prefer. Probably the most
controversial addition would be
data/*/samples/*, since that's nota format that is currently referenced in this codebase. I was using
directories like that to save sample prompts for datasets. Happy to
drop it if its inclusion is not desired.