WIP: Transition to modern cmake #199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: to get the exact build flags, it is probably better to just inspect the generated compile commands.
specifically, this allows to build a static library that actually works
Only use _WIN32 for case distinctions within the code. Otherwise, check via cmake that the required unix headers are present.
N-Maas
force-pushed
the
nikolai/modern-cmake
branch
from
d3a737e
to
486f8ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition to modern cmake and remove git submodules. Should make the build system more stable, adds support for static linking, improves and extends the installation targets, allows direct integration of the C library via cmake via
find_package/FetchContent.Should (mostly) resolve #159, #168, #169 and #173.
I will probably add a few small changes next week, but it could be good to already get some feedback.