Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the go toolchain line #11358

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

dereknola
Copy link
Member

@dereknola dereknola commented Nov 22, 2024

Proposed Changes

We introduced the go toolchain line in #11277, however this line causes issues with the GHA go install action and introduces another level of confusion.

Types of Changes

Verification

Everything is still green across CI and manual testing.

Testing

Linked Issues

User-Facing Change


Further Comments

@dereknola dereknola requested a review from a team as a code owner November 22, 2024 22:31
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.38%. Comparing base (b83f803) to head (8808c12).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11358      +/-   ##
==========================================
- Coverage   46.95%   42.38%   -4.57%     
==========================================
  Files         179      179              
  Lines       18600    18600              
==========================================
- Hits         8733     7883     -850     
- Misses       8512     9512    +1000     
+ Partials     1355     1205     -150     
Flag Coverage Δ
e2etests 34.31% <ø> (-7.82%) ⬇️
inttests 18.82% <ø> (ø)
unittests 13.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dereknola dereknola changed the title Try and remove the toolchain line Remove the go toolchain line Nov 25, 2024
@dereknola dereknola merged commit e138929 into k3s-io:master Nov 25, 2024
30 checks passed
@dereknola dereknola deleted the no_toolchain branch November 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants