Resolve relative paths for root_directory #68
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ./bin/juttle-service resolve relative paths for --root option into an absolute path. Also, in juttle-service constructor, throw error is root_directory option is not provided or if root_directory is not an absolute path. Closes juttle/juttle-engine#69
mattnibs
force-pushed
the
resolve-root-dir
branch
from
c936409
to
ee96c21
Compare
|
@mstemm if this approach is alright, I'll write some tests |
|
+1 I've been wanting this for a while. |
|
closing in favor of #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ./bin/juttle-service, resolve relative paths for --root option.
Also, in juttle-service constructor, throw error if root_directory
option is not provided or if root_directory is not an absolute path.
Closes juttle/juttle-engine#69