-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refetch button to assignment list #1930
Open
KrKOo
wants to merge
2
commits into
jupyter:main
Choose a base branch
from
KrKOo:refetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -293,6 +293,36 @@ class Assignment { | |
|
||
} | ||
} else if (this.data.status == 'fetched') { | ||
var refetchButton = document.createElement('button'); | ||
refetchButton.classList.add('btn', 'btn-danger', 'btn-xs'); | ||
refetchButton.setAttribute('data-bs-toggle', 'tooltip'); | ||
refetchButton.setAttribute('data-bs-placement', 'top'); | ||
Comment on lines
+298
to
+299
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this required ? |
||
refetchButton.setAttribute('style', 'background:#d43f3a; margin-left:5px'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As said above, the style properties could be in common.css. I would also suggest:
|
||
refetchButton.setAttribute('title', 'If you broke any of your assignment files and you want to redownload them, delete those files and click this button to refetch the original version of those files.') | ||
container.append(refetchButton); | ||
|
||
refetchButton.innerText = 'Fetch missing files'; | ||
refetchButton.onclick = async function(){ | ||
refetchButton.innerText = 'Fetching missing files...'; | ||
refetchButton.setAttribute('disabled', 'disabled'); | ||
const dataToSend = { course_id: that.data['course_id'], assignment_id: that.data['assignment_id']}; | ||
try { | ||
const reply = await requestAPI<any>('assignments/fetch_missing', { | ||
body: JSON.stringify(dataToSend), | ||
method: 'POST' | ||
}); | ||
|
||
that.on_refresh(reply); | ||
|
||
} catch (reason) { | ||
remove_children(container); | ||
container.innerText = 'Error fetching missing files.'; | ||
console.error( | ||
`Error on POST /assignment_list/fetch_missing ${dataToSend}.\n${reason}` | ||
); | ||
} | ||
} | ||
|
||
button.innerText = "Submit"; | ||
button.onclick = async function(){ | ||
button.innerText = 'submitting...'; | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class
btn-danger
does not seem to be used.In this case I would call it
btn-warning
, since this is not supposed to overwrite anything.And the style of this class could be defined in the common.css file, like
btn-default
andbtn-primary
.