Skip to content

Commit

Permalink
Merge pull request #390 from julia-vscode/sp/public-version-check
Browse files Browse the repository at this point in the history 
fix: add version check to public kw parsing
  • Loading branch information
@pfitzseb
pfitzseb authored Apr 23, 2024
2 parents 248b35c + 71dd4b7 commit 39528bb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/keywords.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function parse_kw(ps::ParseState; is_toplevel = false)
elseif k === Tokens.PRIMITIVE
return @default ps parse_primitive(ps)
elseif k === Tokens.PUBLIC
if is_toplevel
if is_toplevel && VERSION > v"1.11-"
return @default ps parse_public(ps)
else
return EXPR(:IDENTIFIER, ps)
Expand Down

2 comments on commit 39528bb

@pfitzseb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/105433

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v3.4.3 -m "<description of version>" 39528bb481a83cfeda2a7581a39a05f63ae036b4
git push origin v3.4.3

Please sign in to comment.