Fix torch detach() before numpy() issue
#242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add testing configuration and diarization tests * Add aggregation tests * Add end-to-end test for a sample wav file and several latencies * Fix rounding error in min latency unit test * Improve CI workflows and add pytest. Fix matplotlib colormap error * Install missing dependencies in CI * Add onnxruntime as a test dependency * Update expected timestamp tolerance to up to 50ms
|
Hi @pengwei715, I can't seem to reproduce this error, could you post a minimal reproducible example? I'm suspecting this may also be related to the pytorch version, which one are you using? |
juanmc2005
changed the title
detach() before numpy() issue
|
Hi @juanmc2005 Thank you for the review and feedback. My torch version is |
|
Hi @juanmc2005 , Any news about the issue? |
|
Hi @pengwei715, I haven't had the time to reproduce this. Does the error occur when running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @juanmc2005 ,
This PR is solving the error of complaining torch doesn't have subclass numpy issue. It's just detaching the torch before call numpy(). Please review and let me know your thoughts. BTW, Love your work on the on-line speaker diarization package. Thanks.
Peng