copy collada_to_urdf binary to devel directory #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems ok, where is the test code for collada->urdf and urdf->collada |
|
Does test code mean rostest ? |
|
https://github.com/jsk-ros-pkg/jsk_model_tools/tree/master/euslisp_model_conversion_tester checks something and discussed in #219, jsk-ros-pkg/jsk_model_tools#4. As I comment at there, having test code on different location is not a good idea since everyone will forget about the test code... |
k-okada
added a commit
that referenced
this pull request
May 8, 2014
copy collada_to_urdf binary to devel directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collada_to_urdf was existing only under build directory.
In order to use that binary from other packages, need to copy to devel directory.
Especially, I need this modification for start-jsk/rtmros_gazebo#48 (comment).