[jsk_image_capture] add jsk_image_capture pacakge

[sktometometo]

Add jsk_image_capture package.

TODO

• Add README.md
• Add eusliep client example
• Add Install section.

[k-okada]

did you consider using https://github.com/ros-perception/image_pipeline/blob/noetic/image_view/src/nodes/image_saver.cpp ?

[sktometometo]

@k-okada I know that node. But I need an interface to save an image with a specified file name. That node does not provide it.

[k-okada]

you can set file name via param. It is not clean solution and you might not like it. But if you create client software, it will hide raw interface. https://github.com/ros-perception/image_pipeline/blob/71d537a50bf4e7769af513f4a3d3df0d188cfa05/image_view/src/nodes/image_saver.cpp#L207

…

-- ◉ Kei Okada 2021年11月9日(火) 16:11 Koki Shinjo ***@***.***>:

@k-okada <https://github.com/k-okada> I know that node. But I need an interface to save an image with a specified file name. That node does not provide it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1705 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADYNXAAGGDSLPUWMVX7RZDULDCHPANCNFSM5HULVEPQ> .

[knorth55]

i think the problem of image_saver is that it cannot dynamically change the filename.
the rosparameter is only loaded at the beginning.
I don't know which we should improve image_saver or make a new node is better.

[k-okada]

If so, please consider adding that feature to https://github.com/jsk-ros-pkg/jsk_common/tree/master/jsk_ros_patch/image_view2
adding new feature to existing packages have many advantages;

• existing maintainer will also take care of your new feature
• your feature already have uses/system, so you have more chance to propagate your idea
  Thus, even if you loose interest on that feature, someone will keep maintain it and will use them in their system. So you can put that results within your thesis and you can claim that your developed system is so useful/strong that people keep using them without original developers help.

[sktometometo]

Moved scripts and service files to image_view2.