Fix default processor signature #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
commented
Jan 22, 2020
| }); | ||
|
|
||
| const idlFiles = fs.readdirSync(casesDir); | ||
| describe("with processors", () => { |
There was a problem hiding this comment.
This change doubles the number of tests to validate the transform output with and without processors, which I am not a fan of. It would be preferable to only run the processor tests against the CEReaction.webidl and HTMLConstructor.webidl, but, it is currently impossible with the available webidl2js API.
I am open to any proposal to get around this issue.
There was a problem hiding this comment.
There was a problem hiding this comment.
Agreed, let's move forward with custom elements first. We can always come back to #160 latter.
This was referenced Jan 25, 2020
domenic
approved these changes
Jan 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR fixes a bug that sneaked in fda810e and that was uncaught by the test suite. If you run the current master version of wedidl2js on the master branch of jsdom it breaks all the tests because the default processor signature is invalid.