Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support auto as value for positioning props #123

Closed
wants to merge 2 commits into from

Conversation

idanen
Copy link

@idanen idanen commented Oct 6, 2020

Fixes #122

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #123 into master will increase coverage by 0.23%.
The diff coverage is 35.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
+ Coverage   37.39%   37.62%   +0.23%     
==========================================
  Files          87       87              
  Lines        1182     1188       +6     
  Branches      227      229       +2     
==========================================
+ Hits          442      447       +5     
- Misses        633      634       +1     
  Partials      107      107              
Impacted Files Coverage Δ
lib/properties/bottom.js 0.00% <0.00%> (ø)
lib/properties/left.js 0.00% <0.00%> (ø)
lib/properties/right.js 0.00% <0.00%> (ø)
lib/properties/top.js 0.00% <0.00%> (ø)
lib/parsers.js 80.68% <83.33%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b527ed7...7035224. Read the comment docs.

@idanen
Copy link
Author

idanen commented Nov 1, 2020

@tmpvar @jsakas , any chance someone can look into this anytime soon?

@idanen
Copy link
Author

idanen commented Nov 9, 2020

@domenic maybe?
We really need this PR

@idanen
Copy link
Author

idanen commented Mar 6, 2021

@tmpvar @jsakas friendly reminder?

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 37.62%. Comparing base (b527ed7) to head (7035224).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
lib/properties/bottom.js 0.00% 2 Missing ⚠️
lib/properties/left.js 0.00% 2 Missing ⚠️
lib/properties/right.js 0.00% 2 Missing ⚠️
lib/properties/top.js 0.00% 2 Missing ⚠️
lib/parsers.js 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   37.39%   37.62%   +0.23%     
==========================================
  Files          87       87              
  Lines        1182     1188       +6     
  Branches      227      229       +2     
==========================================
+ Hits          442      447       +5     
- Misses        633      634       +1     
  Partials      107      107              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idanen idanen closed this Sep 29, 2024
@idanen idanen deleted the master branch September 29, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Positioning css properties don't except auto
3 participants