-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exloded war support #484
base: master
Are you sure you want to change the base?
Exloded war support #484
Conversation
Hey I had not noticed this PR... is it not valid anymore? I think the exploded war support would be great to get working! |
Oh, sorry for not providing more context here. The PR worked for us, but then, to make things cleaner and easier for us, I decided to move away from using warbler's main class and pushed everything into pure jruby (basically, If this kind of support may be helpful, I'd be OK with someone taking my code (which is not too different from the existing main class) and running with it, but, unfortunately, I'm not sure I have the time to push this over the finish line and get it merged. |
@kovyrin If you don't mind, I'll reopen this and pull in some other JRuby folks to discuss whether it's a useful feature to add. Thanks for the clarification! |
@kares @mkristian @enebo @jkutner Is this something we want to pursue? |
seems unfinished, would be nice if this was integrated with the existing (WarMain) "main" classes. |
WIP exploded war support