Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exloded war support #484

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Conversation

kovyrin
Copy link

@kovyrin kovyrin commented Jun 11, 2020

WIP exploded war support

@kovyrin kovyrin closed this Oct 26, 2020
@headius
Copy link
Member

headius commented Oct 26, 2020

Hey I had not noticed this PR... is it not valid anymore? I think the exploded war support would be great to get working!

@kovyrin
Copy link
Author

kovyrin commented Oct 26, 2020

Oh, sorry for not providing more context here. The PR worked for us, but then, to make things cleaner and easier for us, I decided to move away from using warbler's main class and pushed everything into pure jruby (basically, java -cp "$JRUBY_STDLIB:$JRUBY_JAR" org.jruby.Main -r rubygems -x"$ENT_SEARCH_WAR_ROOT" -S bin/enterprise-search-internal and then configuring and booting up Jetty from within our custom ruby code), so the need in warbler support for exploded wars went away.

If this kind of support may be helpful, I'd be OK with someone taking my code (which is not too different from the existing main class) and running with it, but, unfortunately, I'm not sure I have the time to push this over the finish line and get it merged.

@headius
Copy link
Member

headius commented Oct 27, 2020

@kovyrin If you don't mind, I'll reopen this and pull in some other JRuby folks to discuss whether it's a useful feature to add. Thanks for the clarification!

@headius headius reopened this Oct 27, 2020
@headius
Copy link
Member

headius commented Oct 27, 2020

@kares @mkristian @enebo @jkutner Is this something we want to pursue?

@kares
Copy link
Member

kares commented Mar 25, 2023

seems unfinished, would be nice if this was integrated with the existing (WarMain) "main" classes.
we could leave it open as a draft or close, your call ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants