Assignment of static signals into registers #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jotego
reviewed
Nov 19, 2024
| assign ind_coin = ~(dipsw[13]^mwalka) & mwalk; | ||
| assign play3 = ~(dipsw[12]^mwalka) & mwalk; | ||
| always @( posedge clk ) begin | ||
| mwalk <= game_id[6]; |
There was a problem hiding this comment.
Note that for this one (mwalk) there is no associated logic so it would require using an additional flip flop. Still, by registering it again in the module, you are allowing the place and route tool to have it closer to the point where it is used so it helps timing too.
If you had not registered it, it may have needed to travel from a far point, accumulating delay.
As there are plenty of unused flip flops, registering inputs is a good practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.