Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wwfss: screen wider and fixed image in Pocket #871

Merged
merged 3 commits into from
Nov 14, 2024
Merged

wwfss: screen wider and fixed image in Pocket #871

merged 3 commits into from
Nov 14, 2024

Conversation

rp-jt
Copy link
Collaborator

@rp-jt rp-jt commented Nov 12, 2024

Video macros are duplicated in macros.def for wwfss. Due to this, there is a discrepancy between the dimensions of the image generated by the core (248x240) and the one unintentionally defined in the macros (256x240).

Removing the duplicates and making both dimensions match partially fixes #866, where, in Pocket, a visual effect is produced in the right side of the screen due to this mismatch is reported.

It is also reported that the image is not centered. Comparing with MAME (which uses 256x240) and PCB footage, it is observed that a small portion at the right side of the screen is missing. I adjusted the horizontal blanking and the macros to fix this, setting the video to 256x240

@rp-jt rp-jt requested a review from jotego November 12, 2024 14:50
@jotego
Copy link
Owner

jotego commented Nov 12, 2024

256x240 is the right one. It should be the same value as in DD.
I think I cut it by 8 pixels because there was a quirk on the right side of the screen with the tilemap (not the objects!). Check if there is something wrong when you scroll around. Thanks.

@rp-jt
Copy link
Collaborator Author

rp-jt commented Nov 14, 2024

@jotego I relocated the blanking to its original position (moving the screen to the left made that sometimes the first scroll pixel could not be charged correctly)

Apparently, the quirks appearing at the right side of the screen were due to the tilemap character layer. Adding 1 to HDUMP_OFFSET in u_char appears to fix it

@jotego jotego merged commit 5b32f5a into master Nov 14, 2024
193 of 198 checks passed
@rp-jt rp-jt deleted the wwf branch November 14, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

WWF Superstars - Analogue Pocket -- Right side of screen shows graphics
2 participants