Changed horizontal mirror logic in k44. Fixes #851 #854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared the mirror logic we had for k44 (
ghf ^ pre_hf ^ hmir_eff
) with the one in Mame.Both tables of truth were slightly different, so I added a small change. The pre_hflip is influenced by the horizontal mirroring, but not the other way, and that was causing the problem in #851. This commit fixes #851
Maybe a similar approach with the vertical flip might help with #724, but I need to check it more thoroughly. I tried changing vflip definition in the same way and the scenes stayed the same