Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed horizontal mirror logic in k44. Fixes #851 #854

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

rp-jt
Copy link
Collaborator

@rp-jt rp-jt commented Oct 22, 2024

Compared the mirror logic we had for k44 (ghf ^ pre_hf ^ hmir_eff ) with the one in Mame.

Both tables of truth were slightly different, so I added a small change. The pre_hflip is influenced by the horizontal mirroring, but not the other way, and that was causing the problem in #851. This commit fixes #851
32

Maybe a similar approach with the vertical flip might help with #724, but I need to check it more thoroughly. I tried changing vflip definition in the same way and the scenes stayed the same

@rp-jt rp-jt requested a review from jotego October 22, 2024 11:38
@jotego jotego merged commit 6a9a01a into master Oct 23, 2024
191 of 197 checks passed
@jotego
Copy link
Owner

jotego commented Oct 23, 2024

It is good. Note that the suffix _eff in signals stands for effective, so it is meant to be used instead of the original signal. In this case, it ends up used together with the original. No big deal, though.

@rp-jt rp-jt deleted the parhair branch October 23, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

paroda: objects in wrong horizontal position
2 participants