Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string include #24

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

keiravillekode
Copy link

In
https://github.com/exercism/wren/actions/runs/6704346582/job/18216581167?pr=137
I noticed the warnings

../../src/cli/cli.c: In function ‘setRootDirectory’:
../../src/cli/cli.c:9:26: warning: implicit declaration of function ‘strlen’ [-Wimplicit-function-declaration]
    9 |   char* copydir = malloc(strlen(dir)+1);
      |                          ^~~~~~
../../src/cli/cli.c:3:1: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
    2 | #include "cli.h"
  +++ |+#include <string.h>
    3 | 
../../src/cli/cli.c:9:[26](https://github.com/exercism/wren/actions/runs/6704346582/job/18216581167?pr=137#step:5:27): warning: incompatible implicit declaration of built-in function ‘strlen’ [-Wbuiltin-declaration-mismatch]
    9 |   char* copydir = malloc(strlen(dir)+1);
      |                          ^~~~~~
../../src/cli/cli.c:9:26: note: include ‘<string.h>’ or provide a declaration of ‘strlen’
../../src/cli/cli.c:10:3: warning: implicit declaration of function ‘strcpy’ [-Wimplicit-function-declaration]
   10 |   strcpy(copydir, dir);
      |   ^~~~~~
../../src/cli/cli.c:10:3: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’
../../src/cli/cli.c:10:3: warning: incompatible implicit declaration of built-in function ‘strcpy’ [-Wbuiltin-declaration-mismatch]
../../src/cli/cli.c:10:3: note: include ‘<string.h>’ or provide a declaration of ‘strcpy’

keiravillekode and others added 2 commits November 1, 2023 19:43
Try bumping to latest Mac runner
@joshgoebel joshgoebel merged commit e293660 into joshgoebel:main Nov 2, 2023
3 checks passed
@keiravillekode keiravillekode deleted the include-string-header branch November 3, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants