Jquery dajaxice #73
Open
Jquery dajaxice #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 25, 2012 14:52
Add a DAJAXICE_JS_LIBRARY option that determines which underlying library to use for making the AJAX call. After the AJAX call is made, the deferred is returned so clients can make additional .success(), .error() or .complete() calls against it.
|
Any plans to accept this? |
|
After struggling with the problem that dajaxice 'does' some (at least by me) unforeseen magic on the jQuery .load function, which can get remedied by setting DAJAXICE_XMLHTTPREQUEST_JS_IMPORT to False in your settings.py file ... I would like to see this patch accepted since it doesn't break the "no-framework" rule but adds better handling for those who use jQuery. Please consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I appreciate not needing to have a particular library (such as jquery) installed, for those of us who do, it is nice to have access to things like jQuery.ajax's deferreds.
This patch keeps the original semantics of no-framework by default. However, if you set DAJAXICE_JS_LIBRARY to 'jquery', the underlying Dajaxice.call is replaced with a jQuery-optimized version that returns the jqxhr object.