Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tab.scss #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

amitranjan2
Copy link

joomla/joomla-cms#23687
This changs are made to fix this issue

@dgrammatiko @C-Lodder

src/scss/tab/tab.scss Outdated Show resolved Hide resolved
@C-Lodder
Copy link
Contributor

C-Lodder commented Feb 7, 2019

This won't work on smaller devices as you can see the wording is cut off.

screenshot_2019-02-07 global configuration - joomla 4 - administration

@amitranjan2
Copy link
Author

@C-Lodder using flex is fine with tab or we can change to something?

@amitranjan2
Copy link
Author

@C-Lodder could you please tell me?
what to do here to solve this?

src/scss/tab/tab.scss Outdated Show resolved Hide resolved
@amitranjan2
Copy link
Author

@ciar4n thanks a lot, now it's working fine

@C-Lodder please look at this

@amitranjan2 amitranjan2 closed this Feb 8, 2019
@amitranjan2 amitranjan2 reopened this Feb 8, 2019
@amitranjan2
Copy link
Author

@ciar4n @C-Lodder this PR need to sorted out for proper working of PR joomla/joomla-cms#23687
please look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants