Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring IpHelper #33

Open
wants to merge 24 commits into
base: 1.x-dev
Choose a base branch
from
Open

Refactoring IpHelper #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
663fdbb
Refactor ArrayHelperTest
nibra Mar 29, 2021
d2d2771
Feature - Add RegEx utility
nibra Mar 30, 2021
66f8083
Style - Fix codestyle issues
nibra Mar 30, 2021
9eb007b
Tests - Remove call to expectedException (not supported in old PHPUni…
nibra Mar 30, 2021
9d21dd0
Compatibility - Add manual implementation for array_filter for PHP <5.6
nibra Mar 30, 2021
7ad3512
Compatibility - PHP 5.3 seems to be unable to deal with static closures
nibra Mar 30, 2021
b85cacc
Style - Closing parenthesis of a multi-line function call must be on …
nibra Mar 30, 2021
805defa
Style - Multi-line function call not indented correctly
nibra Mar 30, 2021
b0b9556
Build - Remove PHPUnit patch
nibra Mar 30, 2021
88e3d56
Tests - Add tests for IpHelper
nibra Mar 31, 2021
78d9c53
Tests - Add test cases for partial invalid network range
nibra Apr 1, 2021
a53173f
Tests - Remove code coverage directive
nibra Apr 1, 2021
0c9b91d
Refactoring - Deprecate IP cache, which made IpHelper a Singleton
nibra Apr 1, 2021
bbd587f
Refactoring - Deprecate global allowOverride, which made IpHelper a S…
nibra Apr 1, 2021
87e0b9e
Refactoring - Remove check for existence of inet_ntop and/or inet_pto…
nibra Apr 1, 2021
2e0ad6e
Refactoring - Remove check for existence of getenv - it is always pre…
nibra Apr 1, 2021
fe93af7
Refactoring - Use strpos instead of strstr (saves memory), use strict…
nibra Apr 1, 2021
55f49b1
Refactoring - Simplify and harden IP detection
nibra Apr 1, 2021
bdcb305
Refactoring - Complete refactoring
nibra Apr 1, 2021
cfabc8e
Refactoring - Prevent inet_pton from emitting a warning
nibra Apr 1, 2021
4a6c287
Style - Add comments
nibra Apr 1, 2021
fdc29aa
Style - Add CS fixes
nibra Apr 1, 2021
c62f29d
Refactoring - Re-add IPinList() as proxy for isInRanges()
nibra Apr 2, 2021
119b8d0
Refactoring - Follow early return pattern, allow REMOTE_ADDR be set i…
nibra Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .drone.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ local composer(phpversion, params) = {
commands: [
"php -v",
"composer update " + params,
if phpversion == "8.0" then "wget https://ci.joomla.org/artifacts/phpunit8_php8_match.patch",
if phpversion == "8.0" then "patch -N -p0 < phpunit8_php8_match.patch"
]
};

Expand Down
22 changes: 1 addition & 21 deletions .drone.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -129,8 +127,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -159,8 +155,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -189,8 +183,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -219,8 +211,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -249,8 +239,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -279,8 +267,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -309,8 +295,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -339,8 +323,6 @@ steps:
commands:
- php -v
- composer update --prefer-stable
- ""
- ""
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand Down Expand Up @@ -369,8 +351,6 @@ steps:
commands:
- php -v
- composer update --ignore-platform-reqs --prefer-stable
- wget https://ci.joomla.org/artifacts/phpunit8_php8_match.patch
- patch -N -p0 < phpunit8_php8_match.patch
volumes:
- name: composer-cache
path: /tmp/composer-cache
Expand All @@ -388,6 +368,6 @@ volumes:

---
kind: signature
hmac: c8067167930c41f3511b5975c080a56617da9b3d7d082940094f8fe381fa0552
hmac: 67a222df6e264e64c1bf1f4661ef9d236c08bb9e4943a9d9c5b00759b048f999

...
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,6 @@ vendor/
composer.phar
composer.lock
phpunit.xml
/.phpunit.result.cache
/build/
/work/
Loading