Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes the use
Joomla\Http\Response
where the values of individual headers are stored as arrays since v2 of thejoomla/http
package. Closes #19.Updates to use
joomla/http
v2 syntax only since v1 support was dropped for some reason in 59268f5.Updates tests to also use
Joomla\Http\Response
class (the use ofstdClass
is what allowed the error to slip by).Testing Instructions
Use the class. Before patch,
TypeError
is thrown insrc\Client.php:116
on PHP 8:On older PHP versions, a warning is emitted and JSON header detection always fails:
Documentation Changes Required
No.