Skip to content

Commit

Permalink
Revert enc28j60 workarounds, my hw is flaky
Browse files Browse the repository at this point in the history
  • Loading branch information
jonlamb-gh committed Oct 17, 2023
1 parent 90130e1 commit 18b53d6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 10 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ The following environment variables can be set:
* `AIR_GRADIENT_BROADCAST_PORT` : The port number to send the broadcast protocol data on, default is `32100`
* `AIR_GRADIENT_BROADCAST_ADDRESS` : The IP address to send the broadcast protocol data to, default is `255.255.255.255`
* `AIR_GRADIENT_DEVICE_PORT` : The port number the device protocol socket listens on, default is `32101`
* `AIR_GRADIENT_LOG` : The max log level filter to use, default is `Info`
* `AIR_GRADIENT_LOG` : The max log level filter to use, default is `INFO`

## FOTA Updating

Expand Down
4 changes: 0 additions & 4 deletions firmware/src/net/eth.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ impl<'buf> Device for Eth<'buf> {
type TxToken<'a> = TxToken<'a> where Self: 'a;

fn receive(&mut self, _timestamp: Instant) -> Option<(Self::RxToken<'_>, Self::TxToken<'_>)> {
// TODO - reading EIR and/or ESTAT appears to resolve rx occasionally not firing?
let _estat = self.drv.estat().ok();
let _eir = self.drv.eir().ok();

match self.drv.next_packet() {
Ok(Some(packet)) => {
let pkt_len = packet.len() as usize;
Expand Down
5 changes: 0 additions & 5 deletions firmware/src/tasks/net.rs
Original file line number Diff line number Diff line change
Expand Up @@ -55,11 +55,6 @@ pub(crate) fn ipstack_poll_timer_task(ctx: ipstack_poll_timer_task::Context) {

pub(crate) fn eth_gpio_interrupt_handler_task(ctx: eth_gpio_interrupt_handler_task::Context) {
let eth = ctx.shared.eth;

// TODO - reading EIR and/or ESTAT appears to resolve rx occasionally not firing?
let _estat = eth.driver().estat().ok();
let _eir = eth.driver().eir().ok();

if eth.driver().interrupt_pending() {
eth.driver().int_pin().clear_interrupt_pending_bit();
ipstack_poll_task::spawn().ok();
Expand Down

0 comments on commit 18b53d6

Please sign in to comment.