Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull the latest Twemoji v14.0.2 set #59

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Pull the latest Twemoji v14.0.2 set #59

wants to merge 25 commits into from

Conversation

makaroni4
Copy link

@makaroni4 makaroni4 commented Jun 15, 2023 •
edited
Loading

This PR pulls the latest Twemoji set with backward compatibility.

Major changes

  • all new keys are based on letters, numbers, and the _ symbol
  • there's a tooling script that can easily import new sets

Before merging

  • Clean up the README file (remove mentions of the forked version)

makaroni4 and others added 25 commits June 12, 2023 09:01
@makaroni4
Replaced CDN URL (jsdelivr.net hosts Twemoji now)
e4801df
@makaroni4
WIP: added a script to download all emojies from unicode.org
810f983
@makaroni4
Download unicode.org emojies and prepare valid emoji list for the lat…
644ef45 
…est version
@makaroni4
Finally, copy new data files to the lib folder
53ec1d9
@makaroni4
Roll back original twemoji lists
12b67af
@makaroni4
Keep old unicode definitions, add new ones from 14.0.2
b013bdb
@makaroni4
Merge old and new unicode names to prevent breaking existing emojies
d6e0658
@makaroni4
Fix specs
d785d81
@makaroni4
More TODO-s before shipping it
dba4c23
@makaroni4
Extracted emoji name generator method to a file, sort absent emojies …
83d92ae 
…to prevent random changes in commits
@makaroni4
Added sorting to emoji data sets to prevent random changes in commits
eb45baf
@makaroni4
DRY emoji CDN URL, doubled CDN check parallelism to speed up tooling …
c1be7d4 
…script
@makaroni4
Fix specs
eb743a0
@makaroni4
Added specs for emojies with multiple keys, switch docs to use single…
ac38ea0 
…-key emoji
@makaroni4
Extracted emoji name fixing to a helper
252f1ca
@makaroni4
Extract emoji validation to a helper method
7fcb853
@makaroni4
Extract CDN validation to a helper
78cb424
@makaroni4
Extract absent emojies file saving to a helper
8c0d996
@makaroni4
Nicely print the final emoji count after CDN validation
6e69396
@makaroni4
Extract final unicode maps preparation into a helper
95821cc
@makaroni4
Added README
241af32
@makaroni4
Fix README typos
a5ac73a
@makaroni4
Added a REAMDE line on how to add this fork to a Rails app
4025292
@makaroni4
Added a README note that it's a fork
32c8ce0
@makaroni4
Fix typo
d27d5ee
@makaroni4 makaroni4 mentioned this pull request Jun 15, 2023
Open
@glebm
Copy link

glebm commented Sep 1, 2024

@huacnlee Can you please look into merging this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@makaroni4 @glebm