Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revert changed vertical alignment of title frame #29

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpcirrus
Copy link

@jpcirrus jpcirrus commented Oct 30, 2024

8f2a59e replaced \vfill with \vfil in the title page minipage but this lowered the vertical alignment of the minipage contents. This commit reverts the vertical alignment to what it was previously.

8f2a59e replaced \vfill with \vfil in the title page minipage but this lowered the vertical alignment of the minipage contents. This commit reverts the vertical alignment to what it was previously.
@jpcirrus
Copy link
Author

jpcirrus commented Oct 30, 2024

However, there remains the issue of the contents of the title page being closer to the top of the frame rather than being centered.

@jolars
Copy link
Owner

jolars commented Oct 31, 2024

Thanks for the PR. I'll take a look at this later today.

@jolars jolars changed the title fix: revert changed vertical alignment of title frame feat: revert changed vertical alignment of title frame Oct 31, 2024
@jolars
Copy link
Owner

jolars commented Oct 31, 2024

I don't know... I think the new title page looks fine for a title page with an image, but when there is no titlegraphic I think it looks better to have it off-centered towards the bottom. Not sure I can motivate it, it just looks that way to me.

Here is a comparison. Before the PR on the left and after on the right.

tmp

Perhaps the margin to the bottom should be fixed instead. I'm not sure what's best here really.

@jpcirrus
Copy link
Author

jpcirrus commented Nov 1, 2024

Just seen #31. Should this PR rather be closed in favour of the flexibility of that proposal?

When the title page has a titlegraphic, absolute centering is accomplished with:

\setbeamertemplate{title page}{
  \begin{minipage}{\textwidth}
    \ifx\inserttitlegraphic\@empty\else\usebeamertemplate*{title graphic}\fi
    \ifx\inserttitle\@empty\else\usebeamertemplate*{title}\fi
    \ifx\insertsubtitle\@empty\else\usebeamertemplate*{subtitle}\fi
    \usebeamertemplate*{title separator}
    \expandafter\ifblank\expandafter{\beamer@andstripped}{}{%
      \usebeamertemplate*{author}%
    }
    \ifx\insertinstitute\@empty\else\usebeamertemplate*{institute}\fi
    \ifx\insertdate\@empty\else\usebeamertemplate*{date}\fi
  \end{minipage}%
}

but for reasons I haven't been able to discover, without a titlegraphic that code results in the contents being slightly raised above center.

@jolars
Copy link
Owner

jolars commented Nov 1, 2024

Just seen #31. Should this PR rather be closed in favour of the flexibility of that proposal?

When the title page has a titlegraphic, absolute centering is accomplished with:

\setbeamertemplate{title page}{
  \begin{minipage}{\textwidth}
    \ifx\inserttitlegraphic\@empty\else\usebeamertemplate*{title graphic}\fi
    \ifx\inserttitle\@empty\else\usebeamertemplate*{title}\fi
    \ifx\insertsubtitle\@empty\else\usebeamertemplate*{subtitle}\fi
    \usebeamertemplate*{title separator}
    \expandafter\ifblank\expandafter{\beamer@andstripped}{}{%
      \usebeamertemplate*{author}%
    }
    \ifx\insertinstitute\@empty\else\usebeamertemplate*{institute}\fi
    \ifx\insertdate\@empty\else\usebeamertemplate*{date}\fi
  \end{minipage}%
}

but for reasons I haven't been able to discover, without a titlegraphic that code results in the contents being slightly raised above center.

Yes, maybe so. Although there might be reason to look into the current, default one, as well. Thanks for the example. A simple centered version of the default seems like a good and easy alternative to have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants