Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #440 - Crash on non-utf8 text file #441

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix issue #440 - Crash on non-utf8 text file #441

wants to merge 2 commits into from

Conversation

clach04
Copy link
Contributor

@clach04 clach04 commented Dec 11, 2022

No description provided.

@clach04 clach04 mentioned this pull request Dec 11, 2022
Open
jmathai
jmathai requested changes Mar 24, 2023
View reviewed changes
Copy link
Owner

@jmathai jmathai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the late review and thanks for the PR. This looks good. Can merge this after a test is added to verify that the invalid json does not throw an exception.

@coveralls
Copy link

Coverage Status

Coverage: 90.44% (-0.2%) from 90.61% when pulling 829db5e on clach04:working_text_files into 76ad823 on jmathai:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmathai jmathai jmathai requested changes

Assignees
No one assigned
Labels
do not merge tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clach04 @coveralls @jmathai