Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle annotations and locations better #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle annotations and locations better #3

wants to merge 2 commits into from

Commits on Jan 13, 2021

  1. Handle annotations and locations better 

    This PR is one of several affecting repositories on Github. It
aims at fixing bad use of annotations (see erl_anno(3)). The
following remarks are common to all PR:s.

Typically the second element of abstract code tuples is assumed
to be an integer, which is no longer always true. For instance,
the parse transform implementing QLC tables (see qlc(3)) returns
code where some annotations are marked as `generated'. Such an
annotation is a list, not an integer (it used to be a negative
integer).

As of Erlang/OTP 24.0, the location can be a tuple {Line, Column},
which is another reason to handle annotations properly.
    @uabboli
    uabboli committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    3e35310 View commit details
    Browse the repository at this point in the history

  2. Substitute Pos for Line 

    Just to clearify that Pos is not necessarily an integer line number.
    @uabboli
    uabboli committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    9ea303a View commit details
    Browse the repository at this point in the history