Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Set the recording timestamp,so can use stream_tags[creation_time] #527

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

cheermao
Copy link
Contributor

Currently recording video files, there is no recording start time label field, add timestamp options , then through the ffprobe command,could get the recording time.
ffprobe -v quiet -show_entries stream_tags=creation_time -of default=noprint_wrappers=1:nokey=1 -i [recordfile] | head -1

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@cheermao cheermao closed this Oct 26, 2023
@cheermao cheermao reopened this Oct 26, 2023
@cheermao
Copy link
Contributor Author

Hi, thanks for your contribution! If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

I have signed the CLA using the email address corresponding to my account.
pls,check it out.

Copy link
Member

@saghul saghul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTTM, thoughts @aaronkvanmeerten ?

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Merging #527 (a0943e3) into master (098b18c) will increase coverage by 0.04%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #527      +/-   ##
============================================
+ Coverage     48.13%   48.18%   +0.04%     
  Complexity      174      174              
============================================
  Files            72       72              
  Lines          2115     2117       +2     
  Branches        201      201              
============================================
+ Hits           1018     1020       +2     
  Misses         1029     1029              
  Partials         68       68              
Files Coverage Δ
.../kotlin/org/jitsi/jibri/capture/ffmpeg/Commands.kt 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 098b18c...a0943e3. Read the comment docs.

@aaronkvanmeerten aaronkvanmeerten merged commit 5af7dd7 into jitsi:master Oct 31, 2023
3 checks passed
@aaronkvanmeerten
Copy link
Member

Thanks for this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants