Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Go version & Dependencies #2753

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Update Go version & Dependencies #2753

merged 2 commits into from
Nov 11, 2024

Conversation

EyalDelarea
Copy link
Contributor

@EyalDelarea EyalDelarea commented Nov 11, 2024 •
edited
Loading

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

@EyalDelarea EyalDelarea added the ignore for release Automatically generated release notes label Nov 11, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
sverdlov93
sverdlov93 reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go 1.23.2 > go 1.23.3

@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@EyalDelarea
Copy link
Contributor Author

I've updated the Jenkinsfile and the dockerfile with the new go version
jfrog/jfrog-ecosystem-integration-env#49 - intergraion-env PR
And also updated our Jenkins tool to go 1.23.3
@sverdlov93

@EyalDelarea EyalDelarea changed the title Update Dependencies Update Go version & Dependencies Nov 11, 2024
@EyalDelarea EyalDelarea merged commit ce3aadc into jfrog:dev Nov 11, 2024
62 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

Assignees
No one assigned
Labels
ignore for release Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EyalDelarea @sverdlov93