truncate node argument at 77 and add '...' at the end

Signed-off-by: Artur Harasimiuk <[email protected]>
jenkinsci · Jun 11, 2019 · ee8f83b · ee8f83b
1 parent b5f51e6
commit ee8f83b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...main/java/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn.java b/...main/java/org/jenkinsci/plugins/workflow/support/visualization/table/ArgumentsColumn.java
@@ -40,7 +40,9 @@ public class ArgumentsColumn extends FlowNodeViewColumn {
     @DataBoundConstructor public ArgumentsColumn() {}
 
     public String get(FlowNode node) {
-        return StringUtils.substring(ArgumentsAction.getStepArgumentsAsString(node), 0, 80);
+        if(StringUtils.length(ArgumentsAction.getStepArgumentsAsString(node))>77)
+            return StringUtils.substring(ArgumentsAction.getStepArgumentsAsString(node), 0, 77) + "...";
+        return ArgumentsAction.getStepArgumentsAsString(node);
     }
 
     @Extension public static class DescriptorImpl extends FlowNodeViewColumnDescriptor {

diff --git a/src/test/java/org/jenkinsci/plugins/workflow/support/visualization/ArgumentsColumnTest.java b/src/test/java/org/jenkinsci/plugins/workflow/support/visualization/ArgumentsColumnTest.java
@@ -31,6 +31,7 @@
 import java.util.Map;
 import java.util.Set;
 
+import org.apache.commons.lang.StringUtils;
 import org.jenkinsci.plugins.workflow.graph.FlowNode;
 import org.jenkinsci.plugins.workflow.graph.StepNode;
 import org.jenkinsci.plugins.workflow.steps.Step;
@@ -81,6 +82,7 @@ public void testLongStepArguments() {
 
         String s = col.get(f);
         assertTrue(s.length()<=80);
+        assertTrue(StringUtils.right(s, 3).equals("..."));
     }