-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add branding settings page #6334
Conversation
Cloudflare Pages deployment
|
We do have an endpoint to upload a custom splash screen to, perhaps we can add support for that in this new branding page? |
Yeah I was thinking about adding that in a separate PR to keep this one smaller. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to work as expected. Some feedback for future improvements:
- Allow uploading the splash image(mentioned in earlier comment)
- Displaying the current splash image
- Maybe rename "splash screen" to "server background image" or something similar to make it a bit more descriptive
- Previewing the login disclaimer for when markdown/html is used
- Use a WYSIWYG editor, may be a bit overkill though
- Use a larger minimum height for both text areas so it's obvious they're not a single line input
Quality Gate passedIssues Measures |
Might be worth adding this feedback here jellyfin/jellyfin-meta#81 also |
These items are either already supported or do not require support by the server. I did create #6335 to track them here though. |
Changes
emby-textarea
componentIssues
N/A