Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add branding settings page #6334

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

thornbill
Copy link
Member

Changes

  • Moves branding settings to a separate dashboard page
  • Fixes some styling issues with the emby-textarea component

Screenshot 2024-11-20 at 18-10-42 Jellyfin

Issues
N/A

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label Nov 20, 2024
@thornbill thornbill added this to the v10.11.0 milestone Nov 20, 2024
@thornbill thornbill requested a review from a team as a code owner November 20, 2024 23:11
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 20, 2024

Cloudflare Pages deployment

Latest commit fbaab4e
Status ✅ Deployed!
Preview URL https://bc974a40.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@nielsvanvelzen
Copy link
Member

We do have an endpoint to upload a custom splash screen to, perhaps we can add support for that in this new branding page?

@thornbill
Copy link
Member Author

Yeah I was thinking about adding that in a separate PR to keep this one smaller. 😉

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work as expected. Some feedback for future improvements:

  • Allow uploading the splash image(mentioned in earlier comment)
  • Displaying the current splash image
  • Maybe rename "splash screen" to "server background image" or something similar to make it a bit more descriptive
  • Previewing the login disclaimer for when markdown/html is used
    • Use a WYSIWYG editor, may be a bit overkill though
  • Use a larger minimum height for both text areas so it's obvious they're not a single line input

Copy link

sonarcloud bot commented Nov 21, 2024

@sjorge
Copy link

sjorge commented Nov 21, 2024

Everything seems to work as expected. Some feedback for future improvements:

* Allow uploading the splash image(mentioned in earlier comment)

* Displaying the current splash image

* Maybe rename "splash screen" to "server background image" or something similar to make it a bit more descriptive

* Previewing the login disclaimer for when markdown/html is used
  
  * Use a WYSIWYG editor, may be a bit overkill though

* Use a larger minimum height for both text areas so it's obvious they're not a single line input

Might be worth adding this feedback here jellyfin/jellyfin-meta#81 also

@thornbill
Copy link
Member Author

Might be worth adding this feedback here jellyfin/jellyfin-meta#81 also

These items are either already supported or do not require support by the server. I did create #6335 to track them here though.

@thornbill thornbill merged commit 20fd822 into jellyfin:master Nov 21, 2024
14 checks passed
@thornbill thornbill deleted the dashboard-branding branch November 21, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants