Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spinner direction (should be clockwise) in @keyframes spin #6324

Open
wants to merge 1 commit into
base: release-10.10.z
Choose a base branch
from
Open

Fix spinner direction (should be clockwise) in @keyframes spin #6324

wants to merge 1 commit into from
+9 −9

Conversation

carsso
Copy link
Contributor

@carsso carsso commented Nov 17, 2024 •
edited
Loading

Changes
Fixing spinner direction (should be clockwise) and removing duplicate animation @keyframes spin

Previous behaviour (spinning in wrong direction, anti-clockwise):
2024-11-17 17 51 25

@carsso carsso requested a review from a team as a code owner November 17, 2024 17:11
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 17, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 3063901
Status ✅ Deployed!
Preview URL https://ff51da9a.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@dmitrylyzo
Copy link
Contributor

Since this is a bugfix, could you please retarget it to the release-10.10.z branch? (#5680 (comment))

dmitrylyzo
dmitrylyzo reviewed Nov 18, 2024
View reviewed changes
src/styles/videoosd.scss
@@ -172,12 +172,6 @@
margin-left: auto;
}

@keyframes spin {
Copy link
Contributor

@dmitrylyzo dmitrylyzo Nov 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this one and remove the one below - less changes and the animation is defined before use.

UPD:
Hmm, maybe another one is for SyncPlay indicators? #1945 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all @keyframes are defined at the end of the file.
I'll create two explicite spin animations, one for clockwise, one for counterclockwise, and use each animation in the right class.

@carsso carsso changed the base branch from master to release-10.10.z November 23, 2024 14:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@carsso
Copy link
Contributor Author

carsso commented Nov 23, 2024

Target changed to release-10.10.z .
Fix updated to handle both spinning directions (one for SyncPlay icon that is counterclockwise, one for player data fetching icon that is clockwise).

@carsso
Copy link
Contributor Author

carsso commented Nov 23, 2024

Works beatifuly for both on preview.

Player data fetching icon :
2024-11-23 15 51 10
SyncPlay icon :
2024-11-23 15 50 10

@dmitrylyzo dmitrylyzo added bug Something isn't working stable backport Backport into the next stable release labels Nov 23, 2024
@dmitrylyzo dmitrylyzo added this to the v10.10.4 milestone Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitrylyzo dmitrylyzo Awaiting requested review from dmitrylyzo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working stable backport Backport into the next stable release
Projects
Jellyfin 10.10
Status: In progress
Milestone
v10.10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@carsso @jellyfin-bot @dmitrylyzo