Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate how overlapping prompt is handled #6323

Closed
wants to merge 2 commits into from

Conversation

AbandonedCart
Copy link

Adds a note to inform the user that an overlapping segment prompt will be discarded in favor of the "Show next video info during playback" prompt.

Changes
Clarifies the action already taken to avoid any confusion, especially for anyone that stops or manually skips before seeing the delayed prompt and doesn't come to the realization themselves.

Issues
Fixes #6322 (by preventing similar confusion)

Adds a note to inform the user that overlapping segment prompt will be discarded in favor of the "Show next video info during playback" prompt.
@AbandonedCart AbandonedCart requested a review from a team as a code owner November 16, 2024 11:22
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 16, 2024

Cloudflare Pages deployment

Latest commit f624c94
Status ✅ Deployed!
Preview URL https://34665d1c.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link

sonarcloud bot commented Nov 16, 2024

@viown
Copy link
Member

viown commented Nov 16, 2024

Maybe we should update the text in the up next dialog to properly indicate the segment.

@AbandonedCart
Copy link
Author

Maybe we should update the text in the up next dialog to properly indicate the segment.

I'm not sure I understand the purpose of that.

@AbandonedCart
Copy link
Author

The wording may be confusing for some.

Other possible ways to word it may be:

  • This dialog will replace ask to skip when displayed during a segment.
  • Segments at the end of a video will only display this dialog.
  • Some other version?

@AbandonedCart AbandonedCart closed this by deleting the head repository Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview "Ask To Skip" - No Button
3 participants