Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plugin category labels #6276

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Update plugin category labels #6276

merged 1 commit into from
Nov 1, 2024

Conversation

thornbill
Copy link
Member

Changes
Prepares for new plugin categories

Issues
N/A

@thornbill thornbill added enhancement Improve existing functionality or small fixes stable backport Backport into the next stable release labels Oct 30, 2024
@thornbill thornbill added this to the v10.10.1 milestone Oct 30, 2024
@thornbill thornbill requested a review from a team as a code owner October 30, 2024 14:47
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 30, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 05de692
Status ✅ Deployed!
Preview URL https://66e6ece1.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@thornbill
Copy link
Member Author

thornbill commented Oct 30, 2024 •
edited
Loading

Maybe this should be deferred to 10.11 since we are lacking good translations for some categories? We just can't really update the plugin categories in advance unless we are okay with them not having translations 🤷‍♂️

On the other hand, this by itself doesn't change the current state of things until we push updated categories to the repository...

@nielsvanvelzen
Copy link
Member

We already need to backport translations for the "ask to skip" media segment action, so if we merge this "in time" we could include the translations updates for this PR as well. Although I understand it might be better to defer that to 10.11.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@thornbill
Copy link
Member Author

I'm convinced... might as well get it in since we are backporting translations for now. Like I said until the updates are pushed to the repo it doesn't change the current state.

@thornbill thornbill merged commit 9ff9f05 into jellyfin:release-10.10.z Nov 1, 2024
14 checks passed
@thornbill thornbill deleted the plugin-categories branch November 1, 2024 18:19
joshuaboniface pushed a commit that referenced this pull request Nov 3, 2024
@thornbill @joshuaboniface
Backport pull request #6276 from jellyfin-web/release-10.10.z
acbb626 
Update plugin category labels

Original-merge: 9ff9f05

Merged-by: thornbill <[email protected]>

Backported-by: Joshua M. Boniface <[email protected]>
@jellyfin-bot jellyfin-bot removed the stable backport Backport into the next stable release label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
enhancement Improve existing functionality or small fixes
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@thornbill @jellyfin-bot @nielsvanvelzen