Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix form dialog modal unnecessary footer button text wrapping #6250

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tylers-username
Copy link
Contributor

Changes
Change form formDialogContent footer buttons (formDialogFooterItem) to only wrap text when the width of the footer area has been completely consumed.

Issues
#6211

@tylers-username tylers-username requested a review from a team as a code owner October 24, 2024 14:32
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 24, 2024

Cloudflare Pages deployment

Latest commit 4bd44e4
Status ✅ Deployed!
Preview URL https://10e5028d.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@dmitrylyzo
Copy link
Contributor

dmitrylyzo commented Oct 24, 2024

Need to test this on webOS 1.2 - flex-basis: fit-content may not be supported.

UPD:
webOS 1.2 and webOS 5 don't support flex-basis: fit-content. Buttons have been rearranged in rows.

Before After
webos-before webos-1

Just a note, buttons now have different sizes.
When changing the UI, it is always better to provide “before” and “after” screens.

Before After
before after

Technically #6211 has been fixed by #6212.

Copy link

sonarcloud bot commented Nov 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants