Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix playing episodes when additional parts exist #6244

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Fix playing episodes when additional parts exist #6244

merged 2 commits into from
Oct 24, 2024

Conversation

thornbill
Copy link
Member

Changes
Fixes the startIndex being incorrect when additional parts exist for episodes

Issues
Fixes #6242

@thornbill thornbill added the bug Something isn't working label Oct 23, 2024
@thornbill thornbill added this to the v10.10.0 milestone Oct 23, 2024
@thornbill thornbill requested a review from a team as a code owner October 23, 2024 21:15
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 23, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 571b280
Status ✅ Deployed!
Preview URL https://35ebb810.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

1hitsong
1hitsong approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change resolved my issue #6242

I tested playback of episodes - both single file and multi part, extras, local trailers, and movies. All worked as expected, no regressions in my tests.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@thornbill thornbill merged commit de87916 into jellyfin:master Oct 24, 2024
14 checks passed
@thornbill thornbill deleted the fix-playing-parts branch October 24, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1hitsong 1hitsong 1hitsong approved these changes

@nielsvanvelzen nielsvanvelzen nielsvanvelzen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
Jellyfin 10.10
Status: Done
Milestone
v10.10.0
Development

Successfully merging this pull request may close these issues.

Having an additional part for a TV episode causes clicking an episode in the season's episode list to be off
4 participants
@thornbill @jellyfin-bot @nielsvanvelzen @1hitsong