-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: playback of series with large set of episodes #5786
base: master
Are you sure you want to change the base?
fix: playback of series with large set of episodes #5786
Conversation
I tested all behavior I could think of to see if this change broke anything - did not find any issues. |
73afdac
to
71c4b6a
Compare
AFAIK, that way you can't switch to the next episode from the player and you have to start each episode manually or start playing the entire show or season. |
Oh that's a good point. |
You were right, it broke that. I will look a bit into how this could be done, but again, if somebody has more knowledge and relevant info to share, please do so! |
Marking as a draft until a working solution is found. |
- fetch episode info for a single episode instead of all episodes in existence
71c4b6a
to
8ce187b
Compare
Cloudflare Pages deployment
|
Quality Gate passedIssues Measures |
Hey! I just rewrote the solution to stop breaking skipping in the player. It does still have some limitations, but IMO it's a good enough solution without adding a new pagination to the player and API itself, which seems like a very large undertaking. The current solution:
|
I also looked into using Therefore limiting to the currently selected season seemed like the best approach to me. |
@dmitrylyzo |
Changes
Fetch episode info for a single episode instead of all episodes when attemtping to start playing an episode.Updated changes: #5786 (comment)
Issues
Fixes #5779