Migrate React Router to React Data Router pattern #4834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
grhallenbeck
force-pushed
the
dev-react-router
branch
from
6fc06c6
to
4c327fc
Compare
grhallenbeck
force-pushed
the
dev-react-router
branch
from
4c327fc
to
9c798f5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
grhallenbeck
force-pushed
the
dev-react-router
branch
from
9c798f5
to
ea17090
Compare
jellyfin-bot
added
merge conflict
This comment was marked as outdated.
This comment was marked as outdated.
grhallenbeck
force-pushed
the
dev-react-router
branch
from
ea17090
to
d2f73d6
Compare
grhallenbeck
force-pushed
the
dev-react-router
branch
from
d2f73d6
to
aad9e36
Compare
This comment was marked as outdated.
This comment was marked as outdated.
grhallenbeck
force-pushed
the
dev-react-router
branch
from
aad9e36
to
c9420da
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Cloudflare Pages deployment
|
grafixeyehero
approved these changes
Oct 28, 2023
thornbill
approved these changes
Nov 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Migrates routing from React Router components to a data router using
createHashRouter. There was logic previously in a custom HistoryRouter implementation that handles syncing a router history between the experimental React application and the legacy router, as well as handling legacy hash-bang routes, which has been moved into auseLegacyRouterSynchook. This allows syncing changes from one router to the other since data routers don't expose their internal history or allow an externally-initialized history.There is some risk here with the history sync logic around potential double history entries, which should be managed with checks against both histories to make sure they aren't already the same before updating one in response to the other. This would probably be a good early target for some unit testing once a testing library has been chosen.
Issues