Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display material icon "movie" when media item has special features #4442

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Display material icon "movie" when media item has special features #4442

wants to merge 2 commits into from

Conversation

SenorSmartyPants
Copy link
Contributor

Which material icon can be easily changed. I thought movie was a good fit.

Movie with special feature(s).
image

Watched movie with 2 versions and special feature(s)
image

Did a little clean up on HTML/CSS for mediaSourceIndicator as well.

@SenorSmartyPants
Copy link
Contributor Author

Suggested change from matrix. Icon with no circle
image
image

@SenorSmartyPants
Copy link
Contributor Author

SenorSmartyPants commented Mar 25, 2023 •
edited
Loading

Suggested change from matrix. Icon with no circle

I think it could use a drop shadow or something to offset it from the background more.

image

@thornbill thornbill added the feature New feature or request label Mar 28, 2023
thornbill
thornbill requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@thornbill thornbill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just a couple minor recommendations.

src/components/cardbuilder/card.scss Show resolved Hide resolved
src/components/cardbuilder/cardBuilder.js Outdated Show resolved Hide resolved
src/components/listview/listview.js Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.0% 1.0% Duplication

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Apr 19, 2023
@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@thornbill
Copy link
Member

@jellyfin-bot rebase

@jellyfin-bot
Copy link
Collaborator

I'm sorry @thornbill, I'm afraid I can't do that.

@SenorSmartyPants SenorSmartyPants requested a review from a team as a code owner September 24, 2023 22:38
@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Sep 24, 2023
@SenorSmartyPants
Copy link
Contributor Author

Rebase, fix merge conflict and force push.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.2% 1.2% Duplication

@jellyfin-bot
Copy link
Collaborator

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

@jellyfin-bot jellyfin-bot added the merge conflict Conflicts prevent merging label Oct 6, 2023
@thornbill thornbill added the ui & ux This PR or issue mainly concerns UI & UX label Feb 20, 2024
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Nov 18, 2024 •
edited
Loading

Cloudflare Pages deployment

Latest commit 81cefe6
Status ✅ Deployed!
Preview URL https://ab0144b5.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

@jellyfin-bot jellyfin-bot removed the merge conflict Conflicts prevent merging label Nov 18, 2024
github-actions[bot]
github-actions bot requested changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/controllers/list.js Show resolved Hide resolved
@SenorSmartyPants
Display material icon "movie" when media item has special features
9329e72 
Which material icon can be easily changed. I thought movie was a good fit.

Remove circle around Special Feature Indicator

Use theme color for icon.
Indicator missing on some pages

Favorites, TV shows, general lists

Code Review: fix case for constant

Fix some rebase merge errors

Fix duplicate key
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@thornbill thornbill Awaiting requested review from thornbill

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature New feature or request ui & ux This PR or issue mainly concerns UI & UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SenorSmartyPants @jellyfin-bot @thornbill