Fix tags and schedule edit for parental control #112
pull_request.yml
on: pull_request_target
Create comments βοΈ
/
CloudFlare Pages deployment ππ
2s
Build ποΈ
/
Run production build ποΈ
3m 23s
Automation ποΈ
/
Merge conflict labeling π·οΈ
2m 3s
Quality checks ππ§ͺ
/
Vulnerable dependencies π
7s
Run eslint suggestions
1m 15s
Matrix: GitHub CodeQL π¬ / analyze
Matrix: Quality checks ππ§ͺ / quality
Deploy π
/
...
/
CloudFlare Pages deployment ππ
5s
Annotations
4 errors, 10 warnings, and 3 notices
Run eslint suggestions
ESLint fails
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/elements/IconButtonElement.tsx#L34
Visible, non-interactive elements with click handlers must have at least one keyboard listener
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/elements/IconButtonElement.tsx#L34
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ
Process completed with exit code 1.
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/components/AppTabs.tsx#L56
Unexpected 'hack' comment: 'HACK: Force resizing to workaround...'
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/access.tsx#L141
React Hook useCallback has a missing dependency: 'libraryMenu'. Either include it or remove the dependency array
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/access.tsx#L239
React Hook useEffect has a missing dependency: 'userId'. Either include it or remove the dependency array
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/parentalcontrol.tsx#L190
React Hook useCallback has a missing dependency: 'libraryMenu'. Either include it or remove the dependency array
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/parentalcontrol.tsx#L316
Unexpected 'fixme' comment: 'FIXME: The following is still hacky and...'
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/parentalcontrol.tsx#L320
Assignments to the 'accessSchedulesPopupCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/parentalcontrol.tsx#L334
Assignments to the 'allowedTagsPopupCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/parentalcontrol.tsx#L340
Assignments to the 'blockedTagsPopupCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/parentalcontrol.tsx#L346
Assignments to the 'formSubmissionCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
|
Quality checks ππ§ͺ / Run lint π΅οΈββοΈ:
src/apps/dashboard/routes/users/profile.tsx#L176
React Hook useCallback has a missing dependency: 'libraryMenu'. Either include it or remove the dependency array
|
Run eslint suggestions
Using ESLint from: /home/runner/work/jellyfin-web/jellyfin-web/node_modules/eslint/lib/api.js
|
Run eslint suggestions
ESLint version: 8.57.1
|
Run eslint suggestions
Using ESLint with default configuration
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
frontend
|
34.6 MB |
|