Skip to content

Fix tags and schedule edit for parental control #112

Fix tags and schedule edit for parental control

Fix tags and schedule edit for parental control #112

Triggered via pull request October 20, 2024 13:52
@gnattugnattu
opened #6231
Status Failure
Total duration 4m 26s
Artifacts 1

pull_request.yml

on: pull_request_target
Create comments ✍️  /  CloudFlare Pages deployment πŸ“ƒπŸš€
2s
Create comments ✍️ / CloudFlare Pages deployment πŸ“ƒπŸš€
Build πŸ—οΈ  /  Run production build πŸ—οΈ
3m 23s
Build πŸ—οΈ / Run production build πŸ—οΈ
Automation πŸŽ›οΈ  /  Merge conflict labeling 🏷️
2m 3s
Automation πŸŽ›οΈ / Merge conflict labeling 🏷️
Quality checks πŸ‘ŒπŸ§ͺ  /  Vulnerable dependencies πŸ”Ž
7s
Quality checks πŸ‘ŒπŸ§ͺ / Vulnerable dependencies πŸ”Ž
Run eslint suggestions
1m 15s
Run eslint suggestions
Matrix: GitHub CodeQL πŸ”¬ / analyze
Matrix: Quality checks πŸ‘ŒπŸ§ͺ / quality
Deploy πŸš€  /  ...  /  CloudFlare Pages deployment πŸ“ƒπŸš€
5s
Deploy πŸš€ / Compose and push comment πŸ“ / CloudFlare Pages deployment πŸ“ƒπŸš€
Fit to window
Zoom out
Zoom in

Annotations

4 errors, 10 warnings, and 3 notices
Run eslint suggestions
ESLint fails
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/elements/IconButtonElement.tsx#L34
Visible, non-interactive elements with click handlers must have at least one keyboard listener
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/elements/IconButtonElement.tsx#L34
Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ
Process completed with exit code 1.
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/components/AppTabs.tsx#L56
Unexpected 'hack' comment: 'HACK: Force resizing to workaround...'
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/access.tsx#L141
React Hook useCallback has a missing dependency: 'libraryMenu'. Either include it or remove the dependency array
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/access.tsx#L239
React Hook useEffect has a missing dependency: 'userId'. Either include it or remove the dependency array
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/parentalcontrol.tsx#L190
React Hook useCallback has a missing dependency: 'libraryMenu'. Either include it or remove the dependency array
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/parentalcontrol.tsx#L316
Unexpected 'fixme' comment: 'FIXME: The following is still hacky and...'
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/parentalcontrol.tsx#L320
Assignments to the 'accessSchedulesPopupCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/parentalcontrol.tsx#L334
Assignments to the 'allowedTagsPopupCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/parentalcontrol.tsx#L340
Assignments to the 'blockedTagsPopupCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/parentalcontrol.tsx#L346
Assignments to the 'formSubmissionCallback' variable from inside React Hook useEffect will be lost after each render. To preserve the value over time, store it in a useRef Hook and keep the mutable value in the '.current' property. Otherwise, you can move this variable directly inside useEffect
Quality checks πŸ‘ŒπŸ§ͺ / Run lint πŸ•΅οΈβ€β™‚οΈ: src/apps/dashboard/routes/users/profile.tsx#L176
React Hook useCallback has a missing dependency: 'libraryMenu'. Either include it or remove the dependency array
Run eslint suggestions
Using ESLint from: /home/runner/work/jellyfin-web/jellyfin-web/node_modules/eslint/lib/api.js
Run eslint suggestions
ESLint version: 8.57.1
Run eslint suggestions
Using ESLint with default configuration

Artifacts

Produced during runtime
Name Size
frontend
34.6 MB