-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IRQ as pin #107
base: master
Are you sure you want to change the base?
Use IRQ as pin #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change has a few issues. It changes all devices to use INT1 e.g. lines 297 & 309.
If this is needed in the Master branch I suggest that the choice of INT0 or INT1 is made selectable with a new varible in each device section which is then used in lines 297 & 309 etc.
Probably also needs a seperate selection area for Yun to avoid conflict with existing ATMEGA32 usage.
11605ee
to
129db4f
Compare
129db4f
to
e3561ba
Compare
Hi Martino, I hope I am not missing something and I am pleased that jeelib has exposure in Itally. However I have concerns with your change for existing users of the library using Leonardo hardware already hardware configured for INT1. Changing the library will trigger problems for them when they next compile. I don't currently see how to combine your wishes with the need to protect the status quo for exiting coders. |
e3561ba
to
d27e4cb
Compare
Hi John, this is Federico the author of this pull request and of the second commit, nice to meet you. I agree with your concern, this new change shall solve the problem. |
d27e4cb
to
5e6fb18
Compare
This patch it's needed in order to set INT1 instead INT0 without need to hardcode it when we are on Leonardo and Yun.
This patch has been tested with this sketch, https://github.com/federicobriata/OpenGarden