Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IRQ as pin #107

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

federicobriata
Copy link

@federicobriata federicobriata commented Jan 28, 2022

This patch it's needed in order to set INT1 instead INT0 without need to hardcode it when we are on Leonardo and Yun.
This patch has been tested with this sketch, https://github.com/federicobriata/OpenGarden

Copy link
Collaborator

@JohnOH JohnOH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change has a few issues. It changes all devices to use INT1 e.g. lines 297 & 309.
If this is needed in the Master branch I suggest that the choice of INT0 or INT1 is made selectable with a new varible in each device section which is then used in lines 297 & 309 etc.
Probably also needs a seperate selection area for Yun to avoid conflict with existing ATMEGA32 usage.

@JohnOH
Copy link
Collaborator

JohnOH commented Nov 14, 2024

Hi Martino, I hope I am not missing something and I am pleased that jeelib has exposure in Itally. However I have concerns with your change for existing users of the library using Leonardo hardware already hardware configured for INT1. Changing the library will trigger problems for them when they next compile.

I don't currently see how to combine your wishes with the need to protect the status quo for exiting coders.

@federicobriata
Copy link
Author

Hi John, this is Federico the author of this pull request and of the second commit, nice to meet you. I agree with your concern, this new change shall solve the problem.
I believe there was a misunderstanding: there is no direct involvement between Arduino with jeelab, I just meet Martino some years ago in fablab Torino in spare time (as we live in the same city) and helped me to use a shield I have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants