Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #709 by introducing multiple_editor_select_via_property #710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mbknor
Copy link

@mbknor mbknor commented Jan 3, 2017

No description provided.

@mbknor
Copy link
Author

mbknor commented Jan 3, 2017

Fixed #709

@mbknor mbknor force-pushed the issue-709-improved-oneOf-selection branch from 56791f7 to 82dc341 Compare January 3, 2017 19:11
@gberche-orange
Copy link

Thanks @mbknor for this contribution. I am trying to reproduce the documented behavior in the PR in the demo.html page served from the PR code

However I don't observe the subeditor being selected (from boy default to girl) in the UI when I click the "update form" button with

{
  "child": {
    "sex": "girl",
    "name": "Gry",
    "age": 5
  }
}

I guess this is because the editor isn't configured by default with the "multiple_editor_select_via_property option. I tried to set it into orange-cloudfoundry@b462050 but I still don't see in effect when serving the modified demo with this option

Must be something stupid on my commit, any hint/suggestion ?

@mbknor
Copy link
Author

mbknor commented Jan 31, 2017

@gberche-orange: The contribution guide specifically says that PR should not commit changes to /dist/ (where the compiled jsonschema-editor is 'located'. Therefor the demo.html you used is not updated. You have to clone my branch and "compile it" as described. Then it works.

btsimonh pushed a commit to btsimonh/json-editor that referenced this pull request May 26, 2021
Fixed a bug that language customization did not reflect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants