Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport model type changed #202

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

Bojana33
Copy link

No description provided.

@Bojana33 Bojana33 requested a review from ivnglkv August 26, 2024 18:32
Copy link
Contributor

@ivnglkv ivnglkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also patch angular_predict.py and mui_predict.py

@@ -22,7 +22,7 @@ async def html5_predict_elements(body):
body_json = json.loads(body_str)
elements_json = body_json.get("elements", [])
document_json = body_json.get("document", "")
viewport_json = body_json.get("viewport", {})
viewport_json = json.loads(body_json.get("viewport", {}))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
viewport_json = json.loads(body_json.get("viewport", {}))
viewport_json = json.loads(body_json.get("viewport", "{}"))

@ivnglkv ivnglkv merged commit 9a96c17 into develop Aug 27, 2024
2 checks passed
@ivnglkv ivnglkv deleted the issue_1598-Pass-screen-resolution-to-selenoid branch August 27, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants