Ignored attributes added in robula model

[Bojana33]

No description provided.

[ivnglkv]

Could be just

Suggested change

	if config["ignored_attributes"] is not None and len(config["ignored_attributes"]) != 0:
	self.attribute_black_list.extend(config["ignored_attributes"])
	self.attribute_black_list = list(dict.fromkeys(self.attribute_black_list))
	if config.ignored_attributes:
	self.attribute_black_list.extend(config.ignored_attributes)

Pydantic guarantees us that ignored_attributes is either None, either list and bool([]) is False so it doesn't make sense to check the length here.

And this line changes nothing

self.attribute_black_list = list(dict.fromkeys(self.attribute_black_list))

[Bojana33]

self.attribute_black_list = list(dict.fromkeys(self.attribute_black_list))
With this line I wanted to make sure that there are no duplicates when we extend the list.

[ivnglkv]

In such cases it's better to leave comment explaining this, because as you can see, it was really not obvious :)
Can we convert self.attribute_black_list to set to avoid having duplicates there?

[Bojana33]

Yes, we can do it with the set too. But in this way we will keep the order of the elements. I will add a comment.

[ivnglkv]

But in this way we will keep the order of the elements

Does it matter?

[Bojana33]

Well in this case it actually doesn't :)

[ivnglkv]

What I actually meant was

class RobulaPlus:
    def __init__(self, element, document, config):
        ...
        self.attribute_black_list = {
            "href",
            "jdn-hash",
             ...,
        }
        ...
        if config.ignored_attributes:
            self.attribute_black_list.update(config.ignored_attributes)

It's much cleaner code and we do less work here. We don't even have to mention something about duplicates in this case.

[ivnglkv]

Why not just

Suggested change

	if config["ignored_attributes"] is not None and len(config["ignored_attributes"]) != 0:
	if config["ignored_attributes"]:

?