Issue 1284: Backend CSS selectors generation #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivnglkv
changed the title
ivnglkv
changed the title
ivnglkv
force-pushed
the
issue_1284-backend-calculation-of-css-selectors
branch
from
81814e6
to
46d3f3e
Compare
No need to rebuild Celery container, it could be just restarted to start working with updated tasks code
Also, not throwing stacktraces to the frontend
…onfusion Failed XPath and CSS locator generation tasks for one element would have the same id
That is essential for processing any real-world amount of elements, otherwise the overhead on creating Chrome instances will be ruining the advantage of making computations on several browsers simultaneously
… cover basically whole function
…with info about elements that task should've processed
ivnglkv
changed the title
…equest be escaped only once
ivnglkv
force-pushed
the
issue_1284-backend-calculation-of-css-selectors
branch
from
c8cfc98
to
c58f395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.