Remove max JDK version check #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Panama/Native vectorization providers have a hardcoded max supported runtime version. This was a reasonable precaution when we were using features under heavy modification in Java 20/21/22. Now, these are becoming somewhat more stable, and this may be causing more pain than it's worth.
As of Java 22+, the sole preview feature we were using was the String template in library loader (and string templates have been removed in Java 23). We previously needed this for FFM, but that became stable in Java 22. The vector support is incubating, not preview, so we don't need the enable-preview flag.
We continue to build jvector-native using release version 22, which ensures that JVector built on new versions will still run on Java 22. We don't know when the vector API will leave incubating, but it will likely depend on the release of Valhalla, so we can't set the max version based on that change.