Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update outdated Prometheus Micrometer code samples #274

Merged

Conversation

varsanyid
Copy link
Contributor

This PR updates the Prometheus Micrometer Plugin samples to drop the removed Companion.create static factory method and invoke the MicrometerPlugin constructor instead.

Whatever TextFormat was when this page was written, it doesn't seem to be available anymore - hence the hardcoded content type in the samples. Let me know if there's a better way to do this

Copy link

github-actions bot commented Aug 3, 2024

🗑 Deploy Preview for javalin.io deleted.

Name Link
🔨 Latest commit fa10e8c
🔍 Latest deploy log https://github.com/javalin/website/actions/runs/10229319660

@tipsy tipsy merged commit 78415a1 into javalin:master Aug 3, 2024
2 checks passed
@varsanyid varsanyid deleted the docs-prometheus-micrometer-example-update branch August 3, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants