Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Biblio tests with Pandoc 3.1.8 #1003

Merged

Conversation

Minoru
Copy link
Collaborator

@Minoru Minoru commented Sep 18, 2023

Fixes #1002.

@jaspervdj, do you think this is a good approach, or should we rather avoid the preprocessor?

@Minoru
Copy link
Collaborator Author

Minoru commented Sep 18, 2023

Checking cabal file in CI is arguably my most important contribution to Hakyll :D I knew I'll screw that one up again eventually!

Copy link
Owner

@jaspervdj jaspervdj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the preprocessor is limited to the tests, I think it's a good solution!

@Minoru Minoru merged commit 3b48802 into jaspervdj:master Sep 20, 2023
21 checks passed
@Minoru Minoru deleted the bugfix/1002-test-fail-with-pandoc-3.1.8 branch September 20, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hakyll.Web.Pandoc.Biblio.Tests failing
2 participants