Modified to use new case-sensitive lowercase logrus import #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, but I'd just like to note that personally I find it preferable for libraries to return errors rather than logging, unless It simply defines a log interface and I can provide my own implementation to harmonise it with the importing app logging. |
|
I agree, but I was just getting it working first, I haven't gone back to that project again and I'm not sure this is even maintained anymore. |
bvandewalle
reviewed
Mar 2, 2018
| "github.com/coreos/go-semver/semver" | ||
| "github.com/sirupsen/logrus" |
There was a problem hiding this comment.
Keep the log package identifier.
It makes it easier to switch for another implementation later on if required.
|
Depending on the dep management tool used, this PR can indeed be pretty useful. Would like to get this in also @janeczku |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sirupsen changed their github account to sirupsen, so this title-case import will have issues with projects using the new lower case import.
Updated to use the new lower-case version.