merge nw/delay into master #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts in includes/library/JamomaDelay.h resolved by using changes in master
…y class, not DRY. see issue #28
…on, but tests fail. see issue #28.
…itting thread safety assertion. see issue #28
… it a bit more. resolved thread safety problem. issue #28
…anOneVectorSize test. issue #28
…umber of non-zero output values. needs more testing to determine if they are in the right place. issue #28
…ingle vector. Still needs testing at edge between vectors. see issue #28
…en vectors. see issue #28
…. branch just needs a bit of clean up before pull request. see issue #28
|
Thanks @tap! With the merge, I believe this closes #28. Further work will continue on the issues you mention. It is worth noting that the method implemented here will likely not work well once #59 is implemented. I realized this when I was reflecting on the work later. It is because it grabs a whole SampleBundles from the history instead of working sample by sample. It's more efficient but may causes issue with modulating parameters. Good enough for now, but the topic will need discussion. And tests will let us know if something breaks along the way. |
|
Good point. There might be need for distinguishing between having a "static delay" vs a "modulated delay". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tap - we now have a linear interpolating delay object. please review.