Add generic font fallbacks & prune some unused styles #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2023
daniel-lewis-ab
added a commit
to daniel-lewis-ab/litegraph.js
that referenced
this pull request
Mar 5, 2024
…s LiteGraph.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sans-serif) to every font specificationh1andh2elements don't seem to be used anywhere outside of the docs, so I pruned them from litegraph-editor.css and editor/style.cssThis makes the UI look better on Linux which doesn't have fonts like Tahoma and Verdana. Personally, I would go further and re-do all of the font assignment based on Boostrap 5's system font stack, to quote, "for optimum text rendering on every device and OS".
But it's be up to the maintainer to say whether this is desirable :)
@atlasan might want to take a look at this as well, since I see they've been editing the CSS